Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial merge of ci.yml and cd.yml workflows to begin testing (no removing live CI workflows yet) #93

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: initial merge of ci.yml and cd.yml workflows to begin testing (no removing live CI workflows yet) #93

merged 1 commit into from
Sep 26, 2024

Conversation

skylar-simoncelli
Copy link
Contributor

No description provided.

@skylar-simoncelli skylar-simoncelli marked this pull request as draft September 23, 2024 09:03
@skylar-simoncelli skylar-simoncelli marked this pull request as ready for review September 23, 2024 10:29
nrdxp
nrdxp reviewed Sep 24, 2024
View reviewed changes
Earthfile Outdated
SAVE ARTIFACT staging_preview_chain_spec.json AS LOCAL staging_preview_chain_spec.json
SAVE ARTIFACT staging_preprod_chain_spec.json AS LOCAL staging_preprod_chain_spec.json

artifacts:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be just a duplication of the build step no? Why do we need to build twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that was actually easier than I thought to consolidate, fixed

nrdxp
nrdxp reviewed Sep 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
./staging_preview_chain_spec.json
./staging_preprod_chain_spec.json

build-artifacts:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just upload the build artifacts from the previous +build step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I need to rewrite so we have a single earthly invocation that builds and exports:

  • ECR docker image
  • partner-chains-node
  • partner-chains-cli
  • chain specs for all 3 environments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done I think!

@nrdxp
Copy link
Contributor

nrdxp commented Sep 24, 2024

This is a massive diff. I think I've wrapped my head around the top-level workflows, but I still need to review the various actions. If it wouldn't be too much trouble, is there anyway you could split this up into a series of PRs to make it a bit simpler to review? I don't want you to waste a day on it, but if its not too hard.

@skylar-simoncelli
Copy link
Contributor Author

This is a massive diff. I think I've wrapped my head around the top-level workflows, but I still need to review the various actions. If it wouldn't be too much trouble, is there anyway you could split this up into a series of PRs to make it a bit simpler to review? I don't want you to waste a day on it, but if its not too hard.

Yeah I wouldn't recommend reading the diff, should be easier to just checkout the branch and follow the logic from there.

There are now only two workflows:

  • ci.yml - Runs automatically on PR-open and is a blocker for merging
  • cd.yml - Manually triggered with a SHA and TAG input, and should handle all deployments, testing and releases

I am testing ci.yml with @rsporny in this PR. Once all tests complete we will merge and move to testing cd.yml

@nrdxp
Copy link
Contributor

nrdxp commented Sep 24, 2024

I am testing ci.yml with @rsporny in this PR. Once all tests complete we will merge and move to testing cd.yml

Alright, you might wanna clean up the commit history a bit before the merge.

@skylar-simoncelli
Copy link
Contributor Author

I am testing ci.yml with @rsporny in this PR. Once all tests complete we will merge and move to testing cd.yml

Alright, you might wanna clean up the commit history a bit before the merge.

Yeah for sure, I'll rebase and squash. Made a mess of the commits in my testing here

@skylar-simoncelli
feat: cicd.yml
f3ae979 
fix: move cicd.yml

feat: modular ghcr

feat: more modules

feat: more modules

feat: local-environment module

feat: no sha

fix: pcsc

fix: path

fix: needs

fix: --node-image

fix: description

feat: more modules

feat: inputs

feat: inputs

feat: parse flake.nix

Run e2e tests on local env (#85)

added:
- run e2e tests workflow

changed:
- use 0.8 slot coeff in MC

feat: move composites

feat: staging-preprod

feat: dir tree

feat: tests

feat: ci + cd

fix: checkouts

feat: more modules

feat: earthly

fix: devshell tests

fix: releases

feat: validator names

feat: chain-specs

feat: keep live workflows

feat: workflow_call > composite

fix: earthly.yml

feat: remove concurency

feat: permissions

fix: permissions

fix: indentation

fix: chain-specs

fix: permissions

fix: earthly-setup

fix: ref

fix: earthly.yml

fix: region

fix: earthly-setup

fix: earthly

feat: remove earthly

fix: main build

fix: if conditions

fix: envs paths

fix: chain-specs

fix: devshell tests

fix: typo

fix: only ci and cd!

fix: always upload chain-specs

feat: simulate merge

feat: checkout for every job

feat: secrets > envs

feat: wait-for-epoch

feat: simplify tests

feat: remove argocd from CI and move to CD

feat: local-environment in CI

fix: don't checkout master

fix: build linux

fix: pcsc

fix: concurrency

fix: remove pcsc

fix: remove concurrency

fix: rename checked out repo in local tests action

add: fallback checkout of pc-tests in local-env-tests workflow

feat: build with earthly

fix: setup

fix: env

fix: earthly artifacts

fix: earthly setup

fix: local-environment tests

fix: ECR REGISTRY

fix: artifact name

fix: artifact names

fix: single earthly

fix: needs

fix: debug

feat: debugging

fix: artifact name

feat: single job

feat: debug

fix: partner-chains-cli

feat: debug

feat: artifact

fix: checkout sha

fix: debug

fix: more debugging

feat: mv

feat: debug

feat: debug

feat: debug

fix: checkout

fix: path

fix: placeholder

fix: path

fix: postgres

fix: node image

feat: debug

fix: overrides

fix: fi

fix: env vars

feat: workflows

fix: run-e2e-tests

fix: run-e2e-tests

feat: argocd too?

fix: path

fix: smoke

fix: PAT

fix: uses

fix: ECR

fix: cd back

fix: always teardown

fix: remove allure

feat: e2e-tests

fix: e2e-tests

feat: rebase

fix: local-env files

Delete dev/local-environment/docker-compose.yml.bak

fix: always tear down

fix: .github

feat: TEST_ENVIRONMENT: CI

feat: pre-merge success marker

fix: pc-demo TEST_ENVIRONMENT

fix: local secrets not encrypted

fix: don't run argo on earthly satellite

fix: wait for epoch action path

fix: ssh auth sock

fix: teardown action

fix: docker compose down

feat: cosmetic post-merge-complete

fix: if

feat: argocd interval

feat: sleep 90

fix: run e2e tests in 4 epochs instead of 7

add: argocd checkout ref_name and fallback

feat: ghcr

fix: checkout e2e tests via ref_name
@skylar-simoncelli skylar-simoncelli merged commit 7208ae2 into master Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LGLO LGLO LGLO left review comments

@nrdxp nrdxp nrdxp left review comments

@gilligan gilligan gilligan approved these changes

@rsporny rsporny rsporny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skylar-simoncelli @nrdxp @gilligan @LGLO @rsporny